Messages in this thread | | | Date | Wed, 19 Oct 2022 16:50:38 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v1 3/6] spi: pxa2xx: Remove no more needed PCI ID table |
| |
On Wed, Oct 19, 2022 at 06:06:04PM +0300, Andy Shevchenko wrote: > On Tue, Oct 18, 2022 at 12:42:03PM +0100, Mark Brown wrote:
> > You should probably also restructure the code interpreting the device > > IDs so that it's very clear that unknown values are handled well, this > > would split things between multiple subsystems and right now the code is > > a bit fragile.
> I'm not sure how better to do this. Any example?
For example a check that the ID is one we know about. IIRC that bit of context looked like a tree of if statements with no particular validation. [unhandled content-type:application/pgp-signature] | |