Messages in this thread | | | Date | Wed, 19 Oct 2022 15:52:12 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller |
| |
On Wed, Oct 19, 2022, at 15:48, Köry Maincent wrote: > Hello Krzysztof, > > On Wed, 19 Oct 2022 09:38:45 -0400 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 19/10/2022 09:32, Köry Maincent wrote: >> > From: Kory Maincent <kory.maincent@bootlin.com> >> > >> > Enable the PL110 DRM driver, used by the spear600. >> > >> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM. >> >> I2C as a user-selectable option should stay. Don't remove such >> (user-selectable) top-level options just because something else selected it. > > As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default. > Why keeping something that is already automatically enabled by CONFIG_DRM?
It's something that DRM probably should not select, so if this ever gets fixed in DRM, you get a broken build. Just leaving the line in there is harmless.
Arnd
| |