lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 228/862] libbpf: Initialize err in probe_map_create
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit 3045f42a64324d339125a8a1a1763bb9e1e08300 ]

    GCC-11 warns about the possibly unitialized err variable in
    probe_map_create:

    libbpf_probes.c: In function 'probe_map_create':
    libbpf_probes.c:361:38: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    361 | return fd < 0 && err == exp_err ? 1 : 0;
    | ~~~~^~~~~~~~~~

    Fixes: 878d8def0603 ("libbpf: Rework feature-probing APIs")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Link: https://lore.kernel.org/bpf/20220801025109.1206633-1-f.fainelli@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/lib/bpf/libbpf_probes.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/lib/bpf/libbpf_probes.c b/tools/lib/bpf/libbpf_probes.c
    index 0b5398786bf3..6d495656f554 100644
    --- a/tools/lib/bpf/libbpf_probes.c
    +++ b/tools/lib/bpf/libbpf_probes.c
    @@ -193,7 +193,7 @@ static int probe_map_create(enum bpf_map_type map_type)
    LIBBPF_OPTS(bpf_map_create_opts, opts);
    int key_size, value_size, max_entries;
    __u32 btf_key_type_id = 0, btf_value_type_id = 0;
    - int fd = -1, btf_fd = -1, fd_inner = -1, exp_err = 0, err;
    + int fd = -1, btf_fd = -1, fd_inner = -1, exp_err = 0, err = 0;

    key_size = sizeof(__u32);
    value_size = sizeof(__u32);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 16:01    [W:4.088 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site