Messages in this thread | | | Date | Wed, 19 Oct 2022 15:11:55 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v4] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm |
| |
On Wed, Oct 19, 2022 at 05:42:18PM +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > In the original mtk_disp_pwm_get_state() function wrongly uses bit 0 of > CON0 to judge if the PWM is enabled. > However that is indicated by a bit (at a machine dependent position) in > the DISP_PWM_EN register. Fix this accordingly. > > Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()") > Signed-off-by: xinlei lee <xinlei.lee@mediatek.com>
Nice commit log text :-)
This now matches the bit that the .apply() callback sets, so looks right.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |