Messages in this thread Patch in this message | | | From | Abel Wu <> | Subject | [PATCH v6 1/4] sched/fair: Skip core update if task pending | Date | Wed, 19 Oct 2022 20:28:56 +0800 |
| |
The function __update_idle_core() considers this cpu is idle so only checks its siblings to decide whether the resident core is idle or not and update has_idle_cores hint if necessary. But the problem is that this cpu might not be idle at that moment any more, resulting in the hint being misleading.
It's not proper to make this check everywhere in the idle path, but checking just before core updating can make the has_idle_core hint more reliable with negligible cost.
Signed-off-by: Abel Wu <wuyun.abel@bytedance.com> Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com> --- kernel/sched/fair.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5ffec4370602..e7f82fa92c5b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6294,6 +6294,9 @@ void __update_idle_core(struct rq *rq) int core = cpu_of(rq); int cpu; + if (rq->ttwu_pending) + return; + rcu_read_lock(); if (test_idle_cores(core)) goto unlock; -- 2.37.3
| |