lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 415/862] memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 61b3c876c1cbdb1efd1f52a1f348580e6e14efb6 ]

    The break of for_each_available_child_of_node() needs a
    corresponding of_node_put() when the reference 'child' is not
    used anymore. Here we do not need to call of_node_put() in
    fail path as '!match' means no break.

    While the of_platform_device_create() will created a new
    reference by 'child' but it has considered the refcounting.

    Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/20220716031324.447680-1-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/pl353-smc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
    index f84b98278745..d39ee7d06665 100644
    --- a/drivers/memory/pl353-smc.c
    +++ b/drivers/memory/pl353-smc.c
    @@ -122,6 +122,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
    }

    of_platform_device_create(child, NULL, &adev->dev);
    + of_node_put(child);

    return 0;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 14:38    [W:2.713 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site