Messages in this thread | | | Date | Wed, 19 Oct 2022 13:01:43 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH] net: macb: Specify PHY PM management done by MAC |
| |
On Wed, Oct 19, 2022 at 12:55:50PM +0300, Sergiu Moga wrote: > The `macb_resume`/`macb_suspend` methods already call the > `phylink_start`/`phylink_stop` methods during their execution so > explicitly say that the PM of the PHY is done by MAC by using the > `mac_managed_pm` flag of the `struct phylink_config`. > > This also fixes the warning message issued during resume: > WARNING: CPU: 0 PID: 237 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0x144/0x148 > > Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
Hi,
You also need to mention that this commit depends on 96de900ae78e in the net tree, which introduced the mac_managed_pm member to phylink_config.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |