lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 610/862] powerpc/pci_dn: Add missing of_node_put()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 110a1fcb6c4d55144d8179983a475f17a1d6f832 ]

    In pci_add_device_node_info(), use of_node_put() to drop the reference
    to 'parent' returned by of_get_parent() to keep refcount balance.

    Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn")
    Co-authored-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
    Link: https://lore.kernel.org/r/20220701131750.240170-1-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/kernel/pci_dn.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c
    index 7a35fc25a304..38561d6a2079 100644
    --- a/arch/powerpc/kernel/pci_dn.c
    +++ b/arch/powerpc/kernel/pci_dn.c
    @@ -330,6 +330,7 @@ struct pci_dn *pci_add_device_node_info(struct pci_controller *hose,
    INIT_LIST_HEAD(&pdn->list);
    parent = of_get_parent(dn);
    pdn->parent = parent ? PCI_DN(parent) : NULL;
    + of_node_put(parent);
    if (pdn->parent)
    list_add_tail(&pdn->list, &pdn->parent->child_list);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 14:22    [W:2.601 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site