| Date | Wed, 19 Oct 2022 14:12:43 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 07/44] serial: 8250: Use uart_xmit_advance() |
| |
On Wed, Oct 19, 2022 at 12:11:14PM +0300, Ilpo Järvinen wrote: > Take advantage of the new uart_xmit_advance() helper.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > drivers/tty/serial/8250/8250_port.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c > index fe8662cd9402..b94e60e75326 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++ b/drivers/tty/serial/8250/8250_port.c > @@ -1842,8 +1842,7 @@ void serial8250_tx_chars(struct uart_8250_port *up) > */ > serial_in(up, UART_SCR); > } > - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); > - port->icount.tx++; > + uart_xmit_advance(port, 1); > if (uart_circ_empty(xmit)) > break; > if ((up->capabilities & UART_CAP_HFIFO) && > -- > 2.30.2 >
-- With Best Regards, Andy Shevchenko
|