lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 355/862] drm/bridge: tc358767: Add of_node_put() when breaking out of loop
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 14e7157afb055248ed34901fcd6fbf54201cfea1 ]

    In tc_probe_bridge_endpoint(), we should call of_node_put() when
    breaking out of the for_each_endpoint_of_node() which will automatically
    increase and decrease the refcount.

    Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT")
    Signed-off-by: Liang He <windhl@126.com>
    Reviewed-by: Robert Foss <robert.foss@linaro.org>
    Signed-off-by: Robert Foss <robert.foss@linaro.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220719065447.1080817-2-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/bridge/tc358767.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
    index 02bd757a8987..1dc107f13645 100644
    --- a/drivers/gpu/drm/bridge/tc358767.c
    +++ b/drivers/gpu/drm/bridge/tc358767.c
    @@ -2010,9 +2010,10 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)

    for_each_endpoint_of_node(dev->of_node, node) {
    of_graph_parse_endpoint(node, &endpoint);
    - if (endpoint.port > 2)
    + if (endpoint.port > 2) {
    + of_node_put(node);
    return -EINVAL;
    -
    + }
    mode |= BIT(endpoint.port);
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 14:01    [W:4.561 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site