lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 573/862] fsi: core: Check error number after calling ida_simple_get
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 35af9fb49bc5c6d61ef70b501c3a56fe161cce3e ]

    If allocation fails, the ida_simple_get() will return error number.
    So master->idx could be error number and be used in dev_set_name().
    Therefore, it should be better to check it and return error if fails,
    like the ida_simple_get() in __fsi_get_new_minor().

    Fixes: 09aecfab93b8 ("drivers/fsi: Add fsi master definition")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Reviewed-by: Eddie James <eajames@linux.ibm.com>
    Link: https://lore.kernel.org/r/20220111073411.614138-1-jiasheng@iscas.ac.cn
    Signed-off-by: Joel Stanley <joel@jms.id.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/fsi/fsi-core.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
    index 3a7b78e36701..5858e6339a10 100644
    --- a/drivers/fsi/fsi-core.c
    +++ b/drivers/fsi/fsi-core.c
    @@ -1314,6 +1314,9 @@ int fsi_master_register(struct fsi_master *master)

    mutex_init(&master->scan_lock);
    master->idx = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
    + if (master->idx < 0)
    + return master->idx;
    +
    dev_set_name(&master->dev, "fsi%d", master->idx);
    master->dev.class = &fsi_master_class;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 13:58    [W:5.083 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site