lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 814/862] HSI: ssi_protocol: fix potential resource leak in ssip_pn_open()
    Date
    From: Jianglei Nie <niejianglei2021@163.com>

    [ Upstream commit b28dbcb379e6a7f80262c2732a57681b1ee548ca ]

    ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When
    hsi_register_port_event() gets some error and returns a negetive value,
    the HSI client's port should be released with hsi_release_port().

    Fix it by calling hsi_release_port() when hsi_register_port_event() fails.

    Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hsi/clients/ssi_protocol.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
    index 21f11a5b965b..49ffd808d17f 100644
    --- a/drivers/hsi/clients/ssi_protocol.c
    +++ b/drivers/hsi/clients/ssi_protocol.c
    @@ -931,6 +931,7 @@ static int ssip_pn_open(struct net_device *dev)
    if (err < 0) {
    dev_err(&cl->device, "Register HSI port event failed (%d)\n",
    err);
    + hsi_release_port(cl);
    return err;
    }
    dev_dbg(&cl->device, "Configuring SSI port\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 13:54    [W:4.095 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site