lkml.org 
[lkml]   [2022]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
    From
    Hi Bjorn,

    On 13/09/2022 11:12, Vidya Sagar wrote:
    > Some of the platforms (like Tegra194 and Tegra234) have open slots and
    > not having an endpoint connected to the slot is not an error.
    > So, changing the macro from dev_err to dev_info to log the event.
    >
    > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
    > ---
    > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
    > index 650a7f22f9d0..25154555aa7a 100644
    > --- a/drivers/pci/controller/dwc/pcie-designware.c
    > +++ b/drivers/pci/controller/dwc/pcie-designware.c
    > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
    > }
    >
    > if (retries >= LINK_WAIT_MAX_RETRIES) {
    > - dev_err(pci->dev, "Phy link never came up\n");
    > + dev_info(pci->dev, "Phy link never came up\n");
    > return -ETIMEDOUT;
    > }
    >


    Are you OK to take this change?

    Acked-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>

    Thanks
    Jon

    --
    nvpublic

    \
     
     \ /
      Last update: 2022-10-18 08:23    [W:5.583 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site