lkml.org 
[lkml]   [2022]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC v1 02/12] dt-bindings: PCI: mediatek-gen3: add support for mt7986
    From
    On 17/10/2022 06:41, Frank Wunderlich wrote:
    > From: Frank Wunderlich <frank-w@public-files.de>
    >
    > Add compatible string for mt7986.
    >
    > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
    > ---
    > mt7986a.dtsi misses clock-names which are now required since support of
    > MT8192/MT8188/MT8195. This change also introduces a 6th clock which is
    > now needed for all pcie-gen3 dts.
    >
    > i do not know how to map the clocks to the names...
    >
    > mediatek-pcie-gen3.yaml:
    >
    > clock-names:
    > items:
    > - const: pl_250m
    > - const: tl_26m
    > - const: tl_96m
    > - const: tl_32k
    > - const: peri_26m
    > - enum:
    > - top_133m # for MT8192
    > - peri_mem # for MT8188/MT8195
    >
    > mt7986a.dtsi:
    >
    > clocks = <&infracfg CLK_INFRA_PCIE_SEL>,
    > <&infracfg CLK_INFRA_IPCIE_CK>,
    > <&infracfg CLK_INFRA_IPCIE_PIPE_CK>,
    > <&infracfg CLK_INFRA_IPCIER_CK>,
    > <&infracfg CLK_INFRA_IPCIEB_CK>;

    Maybe the clock is not required on mt7986?

    Anyway, for the bindings:

    Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-10-18 17:35    [W:7.050 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site