Messages in this thread | | | Date | Tue, 18 Oct 2022 10:24:09 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2] clk: Add trace events for rate requests |
| |
On Tue, 18 Oct 2022 15:56:42 +0200 Maxime Ripard <maxime@cerno.tech> wrote:
> It is currently fairly difficult to follow what clk_rate_request are > issued, and how they have been modified once done. > > Indeed, there's multiple paths that can be taken, some functions are > recursive and will just forward the request to its parent, etc. > > Adding a lot of debug prints is just not very convenient, so let's add > trace events for the clock requests, one before they are submitted and > one after they are returned. > > That way we can simply toggle the tracing on without modifying the > kernel code and without affecting performances or the kernel logs too > much. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
From a tracing point of view:
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> --- > drivers/clk/clk.c | 31 +++++++++++++++++++++++++++++++ > include/trace/events/clk.h | 43 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 74 insertions(+)
| |