Messages in this thread | | | Date | Tue, 18 Oct 2022 13:32:53 +0800 | Subject | Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 | From | Xianting Tian <> |
| |
在 2022/10/18 上午11:19, Bagas Sanjaya 写道: > On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: >> The following interrelated definitions and ranges are needed by the kdump >> crash tool, they are exported by "arch/riscv/kernel/crash_core.c": > Better say "..., which are exported by ..."
will fix it in v3
thanks
> >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 6726f439958c..8e2e164cf3db 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -595,3 +595,33 @@ X2TLB >> ----- >> >> Indicates whether the crashed kernel enabled SH extended mode. >> + >> +RISCV64 >> +======= >> + >> +VA_BITS >> +------- >> + >> +The maximum number of bits for virtual addresses. Used to compute the >> +virtual memory ranges. >> + >> +PAGE_OFFSET >> +----------- >> + >> +Indicates the virtual kernel start address of direct-mapped RAM region. >> + >> +phys_ram_base >> +------------- >> + >> +Indicates the start physical RAM address. >> + >> +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END >> +---------------------------------------------------------------------------------------------------------------------------------------------------- >> + >> +Used to get the correct ranges: >> + >> + * MODULES_VADDR ~ MODULES_END : Kernel module space. >> + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. >> + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. >> + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. >> + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. > The documentation LGTM, thanks. > > When the patch subject is fixed, > > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> >
| |