Messages in this thread | | | Date | Tue, 18 Oct 2022 13:10:18 +0200 | From | Greg KH <> | Subject | Re: [PATCH AUTOSEL 4.19 16/25] wifi: ath10k: reset pointer after memory free to avoid potential use-after-free |
| |
On Tue, Oct 18, 2022 at 11:53:56AM +0200, Pavel Machek wrote: > Hi! > > > From: Wen Gong <quic_wgong@quicinc.com> > > > > [ Upstream commit 1e1cb8e0b73e6f39a9d4a7a15d940b1265387eb5 ] > > > > When running suspend test, kernel crash happened in ath10k, and it is > > fixed by commit b72a4aff947b ("ath10k: skip ath10k_halt during suspend > > for driver state RESTARTING"). > > > > Currently the crash is fixed, but as a common code style, it is better > > to set the pointer to NULL after memory is free. > > > > This is to address the code style and it will avoid potential bug of > > use-after-free. > > We don't have this patch in 4.19: > > b72a4aff947b ("ath10k: skip ath10k_halt during suspend for driver state RESTARTING"). > > We probably should take that one, as this may depend on it. On the > other hand, we don't need this one as it is just a cleanup...
I've dropped this from all queues now, thanks.
greg k-h
| |