lkml.org 
[lkml]   [2022]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 1/3] blktrace: introduce 'blk_trace_swicth_state' helper
On Mon, Oct 17, 2022 at 02:53:19PM +0800, Ye Bin wrote:
> +static int blk_trace_switch_state(struct blk_trace *bt, int start)

This is a very confusing helper. Please split it into two helpers
(e.g. blk_trace_{start,stop}) instead of the awakward int used as
boolean argument that makes it do two entirely unrelated things.

\
 
 \ /
  Last update: 2022-10-18 09:41    [W:0.127 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site