Messages in this thread | | | Date | Tue, 18 Oct 2022 09:23:21 +0200 | Subject | Re: [PATCH] kbuild: use POSIX-compatible grep option | From | Stefan Hansson <> |
| |
Hi Masahiro,
On 2022-10-17 23:31, Masahiro Yamada wrote: > On Tue, Oct 18, 2022 at 12:02 AM Stefan Hansson <newbie13xd@gmail.com> wrote: >> >> --file is a GNU extension to grep which is not available in all >> implementations (such as BusyBox). Use the -f option instead which is >> eqvuialent according to the GNU grep manpage[1] and is present in >> POSIX[2]. >> >> [1] https://www.gnu.org/software/grep/manual/grep.html >> [2] https://pubs.opengroup.org/onlinepubs/9699919799/ > > > This link does not show the spec of grep. > > > Did you mean this? > > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html > >
Yes, sorry, that's a better link. I'm new to this. Do you want me to send a v2 with the commit message updated?
> > > Thanks. > > > > > >> >> Signed-off-by: Stefan Hansson <newbie13xd@gmail.com> >> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index c690361b393f..3513a6db66a2 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR $@ >> cmd_ar_vmlinux.a = \ >> rm -f $@; \ >> $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \ >> - $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt) >> + $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -Ff $(srctree)/scripts/head-object-list.txt) >> >> targets += vmlinux.a >> vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE >> -- >> 2.37.3 >> > >
| |