Messages in this thread | | | Date | Tue, 18 Oct 2022 14:27:16 -0400 | Subject | Re: [PATCH 1/2] dt-bindings: add binding for tft displays based on ilitek,ili9488 | From | Krzysztof Kozlowski <> |
| |
On 18/10/2022 12:45, Tommaso Merciai wrote: > This binding is for the tft displays based on ilitek,ili9488. > waveshare,waveshare,pico-rt-lcd-35 (waveshare pico-restouch-lcd-3.5) > > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > --- > .../bindings/display/ilitek,ili9488.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9488.yaml > > diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9488.yaml b/Documentation/devicetree/bindings/display/ilitek,ili9488.yaml > new file mode 100644 > index 0000000000000..879ecc42c350c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ilitek,ili9488.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/ilitek,ili9488.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ILI9488 display panels device tree bindings
Drop "device tree bindings"
> + > +maintainers: > + - Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com> > + - Michael Trimarchi <michael@amarulasolutions.com> > + - Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > + > +description: > + This binding is for display panels using an Ilitek ILI9488 controller in SPI
Drop "This binding is for" and instead describe hardware.
> + mode. > + > +allOf: > + - $ref: panel/panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + # Waveshare 3.5" 320x480 Color TFT LCD > + - "waveshare,pico-rt-lcd-35" > + - const: ilitek,ili9488 > + > + spi-max-frequency: > + maximum: 20000000 > + > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) > + > + backlight: true > + reg: true > + reset-gpios: true > + rotation: true > + > +required: > + - compatible > + - reg > + - dc-gpios > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
Drop it, no need for this example.
> + }; > + spi { > + #address-cells = <1>; > + #size-cells = <0>;
Use 4 spaces for example indentation.
> + > +
No need for two blank lines.
> + display@0{ > + compatible = "waveshare,pico-rt-lcd-35", "ilitek,ili9488"; > + reg = <0>; > + spi-max-frequency = <20000000>; > + dc-gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>; > + backlight = <&backlight>; > + }; > + }; > + > +...
Best regards, Krzysztof
| |