Messages in this thread | | | Date | Mon, 17 Oct 2022 13:26:12 -0300 | Subject | Re: [PATCH] pstore: migrate to crypto acomp interface (take 2) | From | "Guilherme G. Piccoli" <> |
| |
On 06/10/2022 20:41, Kees Cook wrote: > From: Ard Biesheuvel <ardb@kernel.org> > > The crypto 'compress' interface is deprecated, so before adding new > features, migrate to the acomp interface. Note that we are only using > synchronous implementations of acomp, so we don't have to deal with > asynchronous completion. > > [ Tweaked error paths to avoid memory leak, as pointed out byGuilherme > G. Piccoli <gpiccoli@igalia.com>, and fixed pstore_compress() > return value -kees ] > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > Link: https://lore.kernel.org/lkml/CAMj1kXFnoqj+cn-0dT8fg0kgLvVx+Q2Ex-4CUjSnA9yRprmC-w@mail.gmail.com/ > Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > fs/pstore/platform.c | 74 ++++++++++++++++++++++++++++++++++---------- > 1 file changed, 57 insertions(+), 17 deletions(-) >
Hi Kees, thanks for re-sending this one.
Just tested it on top of v6.0, with efi-pstore/ramoops, using zstd, lz4 and deflate - everything working as expected. So, with the typo fixed, have my:
Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Cheers,
Guilherme
| |