lkml.org 
[lkml]   [2022]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 10/11] kallsyms: Delete an unused parameter related to kallsyms_on_each_symbol()
    Date
    The parameter 'struct module *' in the hook function associated with
    kallsyms_on_each_symbol() is no longer used. Delete it.

    Suggested-by: Petr Mladek <pmladek@suse.com>
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    ---
    include/linux/kallsyms.h | 3 +--
    kernel/kallsyms.c | 5 ++---
    kernel/trace/ftrace.c | 3 +--
    3 files changed, 4 insertions(+), 7 deletions(-)

    diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
    index 0cd33be7142ad0d..5002ebe9dff5a0e 100644
    --- a/include/linux/kallsyms.h
    +++ b/include/linux/kallsyms.h
    @@ -66,8 +66,7 @@ static inline void *dereference_symbol_descriptor(void *ptr)
    }

    #ifdef CONFIG_KALLSYMS
    -int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *,
    - unsigned long),
    +int kallsyms_on_each_symbol(int (*fn)(void *, const char *, unsigned long),
    void *data);
    int kallsyms_on_each_match_symbol(int (*fn)(void *, unsigned long),
    const char *name, void *data);
    diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
    index a1d3aa2c44e8d6f..017fe0570d5f348 100644
    --- a/kernel/kallsyms.c
    +++ b/kernel/kallsyms.c
    @@ -363,8 +363,7 @@ unsigned long kallsyms_lookup_name(const char *name)
    * Iterate over all symbols in vmlinux. For symbols from modules use
    * module_kallsyms_on_each_symbol instead.
    */
    -int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *,
    - unsigned long),
    +int kallsyms_on_each_symbol(int (*fn)(void *, const char *, unsigned long),
    void *data)
    {
    char namebuf[KSYM_NAME_LEN];
    @@ -374,7 +373,7 @@ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *,

    for (i = 0, off = 0; i < kallsyms_num_syms; i++) {
    off = kallsyms_expand_symbol(off, namebuf, ARRAY_SIZE(namebuf));
    - ret = fn(data, namebuf, NULL, kallsyms_sym_address(i));
    + ret = fn(data, namebuf, kallsyms_sym_address(i));
    if (ret != 0)
    return ret;
    cond_resched();
    diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
    index fbf2543111c05c2..e3ef4f0defb2e37 100644
    --- a/kernel/trace/ftrace.c
    +++ b/kernel/trace/ftrace.c
    @@ -8267,8 +8267,7 @@ struct kallsyms_data {
    size_t found;
    };

    -static int kallsyms_callback(void *data, const char *name,
    - struct module *mod, unsigned long addr)
    +static int kallsyms_callback(void *data, const char *name, unsigned long addr)
    {
    struct kallsyms_data *args = data;
    const char **sym;
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-10-17 08:54    [W:2.963 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site