lkml.org 
[lkml]   [2022]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 4.9 11/16] net: korina: Fix return type of korina_send_packet
Hi!

> From: Nathan Huckleberry <nhuck@google.com>
>
> [ Upstream commit 106c67ce46f3c82dd276e983668a91d6ed631173 ]
>
> The ndo_start_xmit field in net_device_ops is expected to be of type
> netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of korina_send_packet should be changed from int to
> netdev_tx_t.

Patches 4-6, 9-11: I see this is nice cleanup for mainline, but ... do
we have CFI in 4.9 tree? This mismatch does not and can not cause any
problems there, right?

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-10-17 12:25    [W:0.559 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site