lkml.org 
[lkml]   [2022]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] null_blk: allow teardown on request timeout
On Mon, Oct 17, 2022 at 09:30:47AM +0000, Chaitanya Kulkarni wrote:
>
> >> + /*
> >> + * Unblock any pending dispatch I/Os before we destroy the device.
> >> + * From null_destroy_dev()->del_gendisk() will set GD_DEAD flag
> >> + * causing any new I/O from __bio_queue_enter() to fail with -ENODEV.
> >> + */
> >> + blk_mq_unquiesce_queue(nullb->q);
> >> +
> >> + null_destroy_dev(nullb);
> >
> > destroying device is never good cleanup for handling timeout/abort, and it
> > should have been the last straw any time.
> >
>
> That is exactly why I've added the rq_abort_limit, so until the limit
> is not reached null_abort_work() will not get scheduled and device is
> not destroyed.

I meant destroying device should only be done iff the normal abort handler
can't recover the device, however, your patch simply destroys device
without running any abort handling.


Thanks,
Ming

\
 
 \ /
  Last update: 2022-10-17 11:51    [W:0.158 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site