lkml.org 
[lkml]   [2022]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH V2 2/9] cpufreq: amd_pstate: add module parameter to load amd pstate EPP driver
    On Tue, Oct 11, 2022 at 12:22:41AM +0800, Yuan, Perry wrote:
    > The amd_pstate mode parameter will allow user to select which amd pstate
    > working mode as booting mode, amd_pstate instance or amd_pstate_epp instance.
    >
    > 1) amd_pstate instance is depending on the target operation mode.
    > 2) amd_pstate_epp instance is depending on the set_policy operation mode.It
    > is also called active mode that AMD SMU has EPP algorithm to control the
    > CPU runtime frequency according to the EPP set value and workload.
    >

    There is one concern here: how can the user know which kind of processor
    supports the EPP function in hardware?

    Thanks,
    Ray

    > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
    > ---
    > drivers/cpufreq/amd-pstate.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
    > index f52b8f2fe529..2d28f458589c 100644
    > --- a/drivers/cpufreq/amd-pstate.c
    > +++ b/drivers/cpufreq/amd-pstate.c
    > @@ -63,6 +63,10 @@ module_param(shared_mem, bool, 0444);
    > MODULE_PARM_DESC(shared_mem,
    > "enable amd-pstate on processors with shared memory solution (false = disabled (default), true = enabled)");
    >
    > +static bool epp = false;
    > +module_param(epp, bool, 0444);
    > +MODULE_PARM_DESC(epp, "Enable energy performance preference (EPP) control");
    > +
    > static struct cpufreq_driver amd_pstate_driver;
    >
    > /**
    > --
    > 2.34.1
    >

    \
     
     \ /
      Last update: 2022-10-17 11:49    [W:4.197 / U:0.696 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site