Messages in this thread | | | From | Brian Norris <> | Subject | [PATCH 0/5] mmc: sdhci controllers: Fix SDHCI_RESET_ALL for CQHCI | Date | Mon, 17 Oct 2022 20:57:19 -0700 |
| |
This is a series of nearly identical fixes for several SDHCI host drivers. The first patch (for sdhci-of-arasan) is the only one I've tested, and I wrote it due to a bug described there.
I then noticed that several other drivers do the same thing, and that commit df57d73276b8 ("mmc: sdhci-pci: Fix SDHCI_RESET_ALL for CQHCI for Intel GLK-based controllers") points out the likely-repeated bug.
Thus, I include additional patches (compile-tested only) that apply similar fixes to the other drivers which call cqhci_init() but not cqhci_deactivate(). They contain appropriate disclaimers and the relevant parties are CC'd. I would suggest only merging them if you get some kind of ACK from people familiar with the relevant hardware.
Notably, I do *not* patch drivers/mmc/host/mtk-sd.c although it uses CQHCI, because it doesn't seem to be an SDHCI-based controller, and so even if it has a similar bug, it's not clear to me how to patch it.
- Brian
Brian Norris (5): mmc: sdhci-of-arasan: Fix SDHCI_RESET_ALL for CQHCI mmc: sdhci-brcmstb: Fix SDHCI_RESET_ALL for CQHCI mms: sdhci-esdhc-imx: Fix SDHCI_RESET_ALL for CQHCI mmc: sdhci-tegra: Fix SDHCI_RESET_ALL for CQHCI mmc: sdhci_am654: Fix SDHCI_RESET_ALL for CQHCI
drivers/mmc/host/sdhci-brcmstb.c | 7 ++++++- drivers/mmc/host/sdhci-esdhc-imx.c | 7 +++++++ drivers/mmc/host/sdhci-of-arasan.c | 17 +++++++++++------ drivers/mmc/host/sdhci-tegra.c | 4 ++++ drivers/mmc/host/sdhci_am654.c | 3 +++ 5 files changed, 31 insertions(+), 7 deletions(-)
-- 2.38.0.413.g74048e4d9e-goog
| |