lkml.org 
[lkml]   [2022]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/4] arm64: dts: qcom: msm8998-oneplus-cheeseburger: fix backlight pin function
    From
    On 11/10/2022 23:31, Krzysztof Kozlowski wrote:
    > There is no "normal" function, so use "gpio" for backlight button pin
    > configuration.
    >
    > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    > ---
    > arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
    > index ef2a88a64d32..122f6c25220e 100644
    > --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
    > +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
    > @@ -35,7 +35,7 @@ &pmi8998_gpio {
    > button_backlight_default: button-backlight-state {
    > pinconf {
    > pins = "gpio5";
    > - function = "normal";
    > + function = "gpio";
    > bias-pull-down;
    > qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
    > };

    Perhaps a Fixes tag would be needed here ?

    Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

    \
     
     \ /
      Last update: 2022-10-17 10:14    [W:2.433 / U:0.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site