lkml.org 
[lkml]   [2022]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] "ACPI: PCC: Fix unintentional integer overflow"
From

在 2022/10/18 2:43, Manank Patel 写道:
> Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL
>
> Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()")
>
> Signed-off-by: Manank Patel <pmanank200502@gmail.com>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
> ---
> Thank you so much @sudeep for your clarifications!
>
> Changelog:
> v1->v2:
> Change the macro itself to ULL instead of typecasting in the
> code
>
> drivers/acpi/acpi_pcc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c
> index ee4ce5ba1fb2..3e252be047b8 100644
> --- a/drivers/acpi/acpi_pcc.c
> +++ b/drivers/acpi/acpi_pcc.c
> @@ -27,7 +27,7 @@
> * Arbitrary retries in case the remote processor is slow to respond
> * to PCC commands
> */
> -#define PCC_CMD_WAIT_RETRIES_NUM 500
> +#define PCC_CMD_WAIT_RETRIES_NUM 500ULL
>
> struct pcc_data {
> struct pcc_mbox_chan *pcc_chan;

Acked-by: Huisong Li <lihuisong@huawei.com>

\
 
 \ /
  Last update: 2022-10-18 03:13    [W:0.082 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site