Messages in this thread Patch in this message | | | Date | Mon, 17 Oct 2022 15:26:20 -0700 | Subject | [PATCH] crypto: x86/polyval - Fix crashes when keys are not 16-byte aligned | From | Nathan Huckleberry <> |
| |
The key_powers array is not guaranteed to be 16-byte aligned, so using movaps to operate on key_powers is not allowed.
Switch movaps to movups.
Fixes: 34f7f6c30112 ("crypto: x86/polyval - Add PCLMULQDQ accelerated implementation of POLYVAL") Reported-by: Bruno Goncalves <bgoncalv@redhat.com> Signed-off-by: Nathan Huckleberry <nhuck@google.com> --- arch/x86/crypto/polyval-clmulni_asm.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/crypto/polyval-clmulni_asm.S b/arch/x86/crypto/polyval-clmulni_asm.S index a6ebe4e7dd2b..32b98cb53ddf 100644 --- a/arch/x86/crypto/polyval-clmulni_asm.S +++ b/arch/x86/crypto/polyval-clmulni_asm.S @@ -234,7 +234,7 @@ movups (MSG), %xmm0 pxor SUM, %xmm0 - movaps (KEY_POWERS), %xmm1 + movups (KEY_POWERS), %xmm1 schoolbook1_noload dec BLOCKS_LEFT addq $16, MSG -- 2.38.0.413.g74048e4d9e-goog
| |