Messages in this thread | | | Date | Mon, 17 Oct 2022 22:56:03 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel |
| |
On Tue, 18 Oct 2022, Deepak R Varma wrote:
> The done_buffer count can be directly read from HDM channel instead of > calling the dim_get_channel_state function. This change also results in > obsoleting the dim_channel_state local structure variable. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > > PLEASE NOTE: I have only built the module on my machine, but have not tested it. > I am not sure how to test this change. I am willing to test it with appropriate > guidance provided I have the necessary hardware.
For non experts, maybe it would be helpful to explain what motivated you to do this?
julia
> > drivers/staging/most/dim2/dim2.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index ab72e11ac5ab..4c1f27898a29 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) > static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > { > struct hdm_channel *hdm_ch = dev->hch + ch_idx; > - struct dim_ch_state_t st; > struct list_head *head; > struct mbo *mbo; > int done_buffers; > @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > spin_lock_irqsave(&dim_lock, flags); > > - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; > + done_buffers = hdm_ch->ch.done_sw_buffers_number; > if (!done_buffers) { > spin_unlock_irqrestore(&dim_lock, flags); > return; > -- > 2.30.2 > > > > >
| |