Messages in this thread | | | Date | Mon, 17 Oct 2022 20:35:57 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 6/6] spi: pxa2xx: Switch from PM ifdeffery to pm_ptr() |
| |
On Mon, Oct 17, 2022 at 06:19:53PM +0100, Mark Brown wrote: > On Mon, Oct 17, 2022 at 08:12:43PM +0300, Andy Shevchenko wrote: > > > Cleaning up the driver to use pm_ptr() macro instead of ifdeffery > > that makes it simpler and allows the compiler to remove those functions > > if built without CONFIG_PM and CONFIG_PM_SLEEP support. > > Are you sure this works cleanly and doesn't suffer from similar problems > to of_match_ptr() when PM is disabled, leaving some unreferenced statics?
Yes, this is the trick with PTR_IF() behind it, which is not used by OF code.
-- With Best Regards, Andy Shevchenko
| |