Messages in this thread | | | Date | Sun, 16 Oct 2022 13:05:29 +0200 | From | Pali Rohár <> | Subject | Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static |
| |
Hello Christophe! Do you have any other comments for this patch series?
On Monday 26 September 2022 11:47:06 Pali Rohár wrote: > On Monday 26 September 2022 09:43:55 Christophe Leroy wrote: > > Le 19/08/2022 à 21:15, Pali Rohár a écrit : > > > Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file. > > > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > > This patch should be squashed into patch 1. > > No problem. Just to explain that I split those changes into different > patches because they touch different files and different board code. > And I thought that different things should be in different patches. > > > > --- > > > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > > index f8d2c97f39bd..9a6d637ef54a 100644 > > > --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > > +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > > @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc) > > > } > > > #endif /* CONFIG_PPC_I8259 */ > > > > > > -void __init mpc85xx_ds_pic_init(void) > > > +static void __init mpc85xx_ds_pic_init(void) > > > { > > > struct mpic *mpic; > > > #ifdef CONFIG_PPC_I8259
| |