Messages in this thread | | | Date | Sun, 16 Oct 2022 09:32:07 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.19 01/63] staging: r8188eu: do not spam the kernel log |
| |
On Thu, Oct 13, 2022 at 06:46:12AM +0200, Greg Kroah-Hartman wrote: >On Wed, Oct 12, 2022 at 08:08:58PM -0700, Joe Perches wrote: >> On Wed, 2022-10-12 at 20:17 -0400, Sasha Levin wrote: >> > From: Michael Straube <straube.linux@gmail.com> >> > >> > [ Upstream commit 9a4d0d1c21b974454926c3b832b4728679d818eb ] >> > >> > Drivers should not spam the kernel log if they work properly. Convert >> > the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use >> > netdev_dbg() instead of pr_info() so that developers can still enable >> > it if they want to see this information. >> >> Why should this be backported? > >I agree, Sasha please drop this from all branches.
I'll drop it, but for the record: I've been picking up patches that help with log spam like any other regular fixes. Being on the receiving end of spammy kernel code and making debugging issues much harder, I think it's as important (if not more) than some other classes of fixes we pick up.
-- Thanks, Sasha
| |