lkml.org 
[lkml]   [2022]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH linux-next] mtd: replace strcmp with sysfs_streq
Hi yexingchen116@gmail.com,

yexingchen116@gmail.com wrote on Sat, 8 Oct 2022 07:46:43 +0000:

> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with sysfs_streq().
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/mtd/parsers/cmdlinepart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/cmdlinepart.c
> b/drivers/mtd/parsers/cmdlinepart.c
> index b34856def816..6a401e0b1b95 100644
> --- a/drivers/mtd/parsers/cmdlinepart.c
> +++ b/drivers/mtd/parsers/cmdlinepart.c
> @@ -154,7 +154,7 @@ static struct mtd_partition * newpart(char *s,
> }
>
> /* if slc is found use emulated SLC mode on this partition*/
> - if (!strncmp(s, "slc", 3)) {
> + if (sysfs_streq(s, "slc")) {

I'm sorry but, why this would be a use for sysfs_streq? The point of
this helper is to consider "\n" null, which is not relevant here. Or do
I miss something?

> add_flags |= MTD_SLC_ON_MLC_EMULATION;
> s += 3;
> }


Thanks,
Miquèl

\
 
 \ /
  Last update: 2022-10-15 11:08    [W:0.073 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site