Messages in this thread Patch in this message | | | From | Adrian Hunter <> | Subject | [PATCH 1/7] perf test: test_intel_pt.sh: Fix return checking again | Date | Fri, 14 Oct 2022 20:08:59 +0300 |
| |
count_result() does not always reset ret=0 which means the value can spill into the next test result.
Fix by explicitly setting it to zero between tests.
Fixes: fd9b45e39cfa ("perf test: test_intel_pt.sh: Fix return checking") Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- tools/perf/tests/shell/test_intel_pt.sh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/perf/tests/shell/test_intel_pt.sh b/tools/perf/tests/shell/test_intel_pt.sh index efaad9566c34..4609a24c9340 100755 --- a/tools/perf/tests/shell/test_intel_pt.sh +++ b/tools/perf/tests/shell/test_intel_pt.sh @@ -265,13 +265,12 @@ count_result() return fi err_cnt=$((err_cnt + 1)) - ret=0 } ret=0 -test_system_wide_side_band || ret=$? ; count_result $ret -test_per_thread "" "" || ret=$? ; count_result $ret -test_per_thread "k" "(incl. kernel) " || ret=$? ; count_result $ret +test_system_wide_side_band || ret=$? ; count_result $ret ; ret=0 +test_per_thread "" "" || ret=$? ; count_result $ret ; ret=0 +test_per_thread "k" "(incl. kernel) " || ret=$? ; count_result $ret ; ret=0 cleanup -- 2.25.1
| |