Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 14 Oct 2022 18:21:23 +0200 | Subject | Re: [PATCH] scripts: rust_is_available.sh: Provide hints on how to fix missing pieces |
| |
On Tue, Oct 4, 2022 at 8:47 PM Olof Johansson <olof@lixom.net> wrote: > > This might be a bit bikesheddy, but it saves a few roundtrips to the > documentation when getting the `make LLVM=1 rustavailable` run to pass.
It is faster for someone that already knows how things work, but it may make newcomers skip the docs and it duplicates the information there. In addition, for the non-error case, it makes it more verbose which may not be appreciated. So maybe we should point to the docs instead? What do you think?
Also, the patch doesn't add instructions for all the cases, so somebody that may have hit one of the documented ones + not have read the docs may wonder where to find them the solution or why they are missing.
Thanks!
Cheers, Miguel
| |