Messages in this thread | | | Date | Thu, 13 Oct 2022 10:21:18 -0600 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible |
| |
On Thu, Oct 13, 2022 at 01:40:40PM +0200, Rolf Eike Beer wrote: > Am Donnerstag, 13. Oktober 2022, 12:16:35 CEST schrieb Florian Westphal: > > Rolf Eike Beer <eike-kernel@sf-tec.de> wrote: > > > Florian, can you comment and maybe fix it? > > > > Can't comment, do not remember -- this was 5 years ago. > > > > > Or you wanted to move the variable before the loop and keep the random > > > state between the loops and only reseed when all '1' bits have been > > > consumed. > > Probably. No clue, best to NOT change it to not block Jasons series and > > then just simplify this and remove all the useless shifts. > > Sure. Jason, just in case you are going to do a v7 this could move to u8 then.
Indeed I think this is one to send individually to netdev@ once the tree opens there for 6.2.
Jason
| |