lkml.org 
[lkml]   [2022]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/1] tty: n_gsm: make n_gsm line number configurable
On Thu, Oct 13, 2022 at 11:09:02AM +0000, Starke, Daniel wrote:
> > > --- a/include/uapi/linux/gsmmux.h
> > > +++ b/include/uapi/linux/gsmmux.h
> > > @@ -19,7 +19,9 @@ struct gsm_config
> > > unsigned int mtu;
> > > unsigned int k;
> > > unsigned int i;
> > > - unsigned int unused[8]; /* Padding for expansion without
> > > + unsigned short numValid;
> > > + unsigned short num;
> >
> > This would never work anyway (hint "short" is not a valid uapi data
> > type...)
>
> I am surprised about this as gsm_netconfig already uses unsigned short.

How does netconfig pass data to/from userspace? Through ioctls or
netlink?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-10-13 14:57    [W:0.825 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site