Messages in this thread | | | Subject | RE: [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement | From | Daejun Park <> | Date | Fri, 14 Oct 2022 09:19:00 +0900 |
| |
Hi Bean,
> LUs with WB potential support are properly checked in ufshcd_wb_probe() > before calling ufshcd_read_unit_desc_param(), so remove this unnecessary > if-checkup in ufs_is_valid_unit_desc_lun() to match its function definition. > > Signed-off-by: Bean Huo <beanhuo@micron.com> > --- > drivers/ufs/core/ufshcd-priv.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h > index f68ca33f6ac7..2457b005101a 100644 > --- a/drivers/ufs/core/ufshcd-priv.h > +++ b/drivers/ufs/core/ufshcd-priv.h > @@ -300,9 +300,6 @@ static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info, > pr_err("Max General LU supported by UFS isn't initialized\n"); > return false; > } > - /* WB is available only for the logical unit from 0 to 7 */ > - if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)
Then, there is no requirement for "param_offset" argument.
Thanks, Daejun
| |