lkml.org 
[lkml]   [2022]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err()
Date
Hi Yang,

Dne četrtek, 29. september 2022 ob 07:40:03 CEST je Yang Li napisal(a):
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2314
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index
> 8b99c17e8403..9119f5e0e05e 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -913,7 +913,6 @@ static int sun6i_csi_resources_setup(struct
> sun6i_csi_device *csi_dev,
>
> irq = platform_get_irq(platform_dev, 0);
> if (irq < 0) {
> - dev_err(dev, "failed to get interrupt\n");
> ret = -ENXIO;
> goto error_clock_rate_exclusive;
> }
> --
> 2.20.1.7.g153144c


\
 
 \ /
  Last update: 2022-10-13 00:08    [W:0.107 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site