Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 12 Oct 2022 10:42:19 -0700 | Subject | Re: [PATCH 2/2] dt-bindings: pinctrl: qcom,sc7180: convert to dtschema |
| |
Hi,
On Fri, Oct 7, 2022 at 7:51 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > + drive-strength: > + enum: [2, 4, 6, 8, 10, 12, 14, 16] > + default: 2 > + description: > + Selects the drive strength for the specified pins, in mA.
The "default" of 2 is not correct. Please see commit 768f8d8e45f9 ("dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified")
In fact, are you sure this even needs to be replicated here? This is part of the common "qcom,tlmm-common.yaml" bindings file, isn't it?
-Doug
| |