lkml.org 
[lkml]   [2022]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] wifi: ath10k: Delay the unmapping of the buffer
Date
Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2022-10-12 at 19:57 +0530, Youghandhar Chintala wrote:
>>
>> @@ -418,6 +426,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>> .dynamic_sar_support = false,
>> .hw_restart_disconnect = false,
>> .use_fw_tx_credits = true,
>> + .delay_unmap_buffer = false,
>>
>
> All the false are unnecessary and just distract from the content, imho.

In this case I actually prefer having explicitly set false (and zero),
it makes it easier to maintain the correct order and compare between
hardware values.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2022-10-12 17:31    [W:0.037 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site