lkml.org 
[lkml]   [2022]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules
From
On 12/10/2022 04:39, jerome Neanne wrote:
>> You explained what you did, which is easily visible. You did not explain
>> why you are doing it.
>>
>> Best regards,
>> Krzysztof
>>
> Thanks for pointing me to the detailed guidelines
> I'm new to upstream and not well aware of all good practices.
>
> Would below commit message be more suitable:
>
> Add support for the TPS65219 PMIC by enabling MFD, regulator and
> power-button drivers. All drivers enabled as modules.

This still says only what you did. I still does not explain why.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-10-12 15:00    [W:0.092 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site