Messages in this thread | | | From | Masami Hiramatsu <> | Date | Wed, 12 Oct 2022 12:21:11 +0100 | Subject | Re: [PATCH] selftests/ftrace: fix dynamic_events dependency check |
| |
Hi Sven,
2022年10月10日(月) 8:42 Sven Schnelle <svens@linux.ibm.com>: > > commit 95c104c378dc ("tracing: Auto generate event name when creating a > group of events") changed the syntax in the ftrace README file which is > used by the selftests to check what features are support. Adjust the > string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work > again. > > Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events") > Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Thanks for fixing it!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> --- > .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +- > .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > index db522577ff78..d3a79da215c8 100644 > --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > @@ -1,7 +1,7 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: Generic dynamic event - check if duplicate events are caught > -# requires: dynamic_events "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README > +# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README > > echo 0 > events/enable > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc > index 914fe2e5d030..6461c375694f 100644 > --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc > @@ -1,7 +1,7 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: event trigger - test inter-event histogram trigger eprobe on synthetic event > -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README > +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README > > echo 0 > events/enable > > -- > 2.34.1 >
-- Masami Hiramatsu mailto:masami.hiramatsu@gmail.com
| |