Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 11 Oct 2022 13:34:44 -0700 | Subject | Re: [PATCH 1/1] scripts/clang-tools: Convert clang-tidy args to list |
| |
On Tue, Oct 11, 2022 at 12:06 PM Guru Das Srinagesh <quic_gurus@quicinc.com> wrote: > > Convert list of clang-tidy arguments to a list for ease of adding to > them and extending them as required. > > Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> > Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Masahiro, would you please be able to carry this up through the kbuild tree?
> --- > scripts/clang-tools/run-clang-tools.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py > index bb78c9b..56f2ec8 100755 > --- a/scripts/clang-tools/run-clang-tools.py > +++ b/scripts/clang-tools/run-clang-tools.py > @@ -45,13 +45,14 @@ def init(l, a): > > def run_analysis(entry): > # Disable all checks, then re-enable the ones we want > - checks = "-checks=-*," > + checks = [] > + checks.append("-checks=-*") > if args.type == "clang-tidy": > - checks += "linuxkernel-*" > + checks.append("linuxkernel-*") > else: > - checks += "clang-analyzer-*" > - checks += ",-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling" > - p = subprocess.run(["clang-tidy", "-p", args.path, checks, entry["file"]], > + checks.append("clang-analyzer-*") > + checks.append("-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling") > + p = subprocess.run(["clang-tidy", "-p", args.path, ",".join(checks), entry["file"]], > stdout=subprocess.PIPE, > stderr=subprocess.STDOUT, > cwd=entry["directory"]) > -- > 2.7.4 >
-- Thanks, ~Nick Desaulniers
| |