Messages in this thread | | | Date | Tue, 11 Oct 2022 21:44:34 +0200 | Subject | Re: [PATCH] staging: rtl8192e: Remove single statement braces | From | Philipp Hortmann <> |
| |
On 10/10/22 21:02, Dragan Cvetic wrote: > Remove braces around single line statement, to resolve checkpatch.pl > warnings "braces {} are not necessary for single statement blocks" > > Signed-off-by: Dragan Cvetic <dragan.m.cvetic@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > index 702551056227..d7bfaf68291c 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > @@ -267,10 +267,8 @@ static void _rtl92e_dm_check_ac_dc_power(struct net_device *dev) > "PATH=/usr/bin:/bin", > NULL}; > > - if (priv->ResetProgress == RESET_TYPE_SILENT) { > + if (priv->ResetProgress == RESET_TYPE_SILENT) > return; > - } > - > if (priv->rtllib->state != RTLLIB_LINKED) > return; > call_usermodehelper(ac_dc_script, argv, envp, UMH_WAIT_PROC); > @@ -330,9 +328,8 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev) > bool bshort_gi_enabled = false; > static u8 ping_rssi_state; > > - if (!priv->up) { > + if (!priv->up) > return; > - } > > if (pra->rate_adaptive_disabled) > return; > @@ -777,9 +774,8 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(struct net_device *dev) > tmpRegA = rtl92e_get_bb_reg(dev, rOFDM0_XATxIQImbalance, > bMaskDWord); > for (i = 0; i < OFDM_Table_Length; i++) { > - if (tmpRegA == OFDMSwingTable[i]) { > + if (tmpRegA == OFDMSwingTable[i]) > priv->OFDM_index[0] = i; > - } > } > > TempCCk = rtl92e_get_bb_reg(dev, rCCK0_TxFilter1, bMaskByte2); > @@ -1066,9 +1062,8 @@ void rtl92e_dm_restore_state(struct net_device *dev) > u32 reg_ratr = priv->rate_adaptive.last_ratr; > u32 ratr_value; > > - if (!priv->up) { > + if (!priv->up) > return; > - } > > if (priv->rate_adaptive.rate_adaptive_disabled) > return;
This patch interferes with: [PATCH v3] staging: rtl8192e: remove unnecessary braces for single statement blocks from: me@lirui.org
Bye Philipp
| |