Messages in this thread | | | Date | Tue, 11 Oct 2022 11:22:36 -0700 | Subject | Re: [PATCH v5 13/13] tty: gunyah: Add tty console driver for RM Console Services | From | Elliot Berman <> |
| |
On 10/10/2022 11:02 PM, Jiri Slaby wrote: >> + char *co_xmit_buf[2]; >> + int co_xmit_idx; >> + unsigned int co_xmit_count; >> + spinlock_t co_xmit_lock; >> + struct work_struct co_flush_work; >> +}; >> + >> +static int rm_cons_notif_handler(struct notifier_block *nb, unsigned >> long cmd, void *data) >> +{ >> + int count, i; >> + struct rm_cons_port *rm_port = NULL; >> + struct tty_port *tty_port = NULL; >> + struct rm_cons_drv_data *cons_data = >> + container_of(nb, struct rm_cons_drv_data, rm_cons_notif); >> + const struct gh_rm_notification *notif = data; >> + struct gh_rm_notif_vm_console_chars const * const msg = notif->buff; > > So you did not comment on/address all my notes? >
Apologies Jiri, I wanted to get some consensus on direction to take the RM console driver and missed out the sorting here.
| |