lkml.org 
[lkml]   [2022]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mmc: sdhci-sprd: Fix minimum clock limit
From
On 11/10/22 09:30, Wenchao Chen wrote:
> From: Wenchao Chen <wenchao.chen@unisoc.com>
>
> The minimum clock supported by SPRD Host is 100000.

Commit messages are better if they say why a change
is being made.

This begs the question, was there a problem with 400 kHz?
Are there cases that benefit from this change?
Should it have a fixes tag,cc stable?

>
> Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 46c55ab4884c..b92a408f138d 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -309,7 +309,7 @@ static unsigned int sdhci_sprd_get_max_clock(struct sdhci_host *host)
>
> static unsigned int sdhci_sprd_get_min_clock(struct sdhci_host *host)
> {
> - return 400000;
> + return 100000;
> }
>
> static void sdhci_sprd_set_uhs_signaling(struct sdhci_host *host,

\
 
 \ /
  Last update: 2022-10-11 08:46    [W:0.039 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site