Messages in this thread | | | From | Liam Howlett <> | Subject | Re: [PATCH v14 07/70] lib/test_maple_tree: add testing for maple tree | Date | Tue, 11 Oct 2022 16:13:02 +0000 |
| |
* Geert Uytterhoeven <geert@linux-m68k.org> [221011 14:59]: > Hi Matthew, > > On Tue, Oct 11, 2022 at 2:56 PM Matthew Wilcox <willy@infradead.org> wrote: > > On Tue, Oct 11, 2022 at 02:16:02PM +0200, Geert Uytterhoeven wrote: > > > > lib/test_maple_tree.c | 38307 ++++++++++++++++++++++++++++ > > > > > > Does this test really belong under lib/? > > > All other test modules there can be compiled and run as part of the > > > kernel itself. > > > > So can this. It's just like test_ida and test_xarray; it can be > > built as a module, or it can be extracted into userspace and run there. > > How so? I can't seem to find the glue to do so, or the Kconfig symbol > to enable the test module. > > It's different for test_ida and test_xarray: > > lib/Makefile:obj-$(CONFIG_TEST_IDA) += test_ida.o > lib/Makefile:obj-$(CONFIG_TEST_XARRAY) += test_xarray.o > > What am I missing? > Thanks! >
Thanks for pointing this out. I must have dropped this over the development cycle. I'll re-add it.
> Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |