Messages in this thread | | | Date | Tue, 11 Oct 2022 17:05:17 +0300 | Subject | Re: [PATCH 11/13] phy: qcom-qmp-combo: drop power-down delay config | From | Dmitry Baryshkov <> |
| |
On 11/10/2022 16:14, Johan Hovold wrote: > The power-down delay was included in the first version of the QMP driver > as an optional delay after powering on the PHY (using > POWER_DOWN_CONTROL) and just before starting it. Later changes modified > this sequence by powering on before initialising the PHY, but the > optional delay stayed where it was (i.e. before starting the PHY). > > The vendor driver does not use a delay before starting the PHY and this > is likely not needed on any platform unless there is a corresponding > delay in the vendor kernel init sequence tables (i.e. in devicetree). > > Let's keep the delay for now, but drop the redundant delay period > configuration while increasing the unnecessarily low timer slack > somewhat. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |